Improve error messages for unsupported __audit database operations#18309
Merged
CRZbulabula merged 2 commits intoJul 25, 2026
Conversation
4 tasks
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18309 +/- ##
============================================
+ Coverage 42.83% 42.87% +0.04%
Complexity 374 374
============================================
Files 5362 5362
Lines 381409 381600 +191
Branches 49509 49553 +44
============================================
+ Hits 163368 163623 +255
+ Misses 218041 217977 -64 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Replace the misleading
read-onlyerror used for unsupported operations on the audit database with a more accurate message:The message is shared by the tree-model and table-model authorization paths and is localized in both English and Chinese.
This PR also fixes the internal audit writer exemption in
TreeAccessCheckVisitor. The check now comparesINTERNAL_AUDIT_USERwith the request username instead of the target path.Affected operations
__audit.root.__audit.Test coverage
DELETE DATABASE root.__auditand template operations inIoTDBTemplateAuthIT.IoTDBSeriesPermissionIT.DROP DATABASE __auditinIoTDBAuthenticationTableIT.Verified with:
mvn spotless:apply -pl iotdb-core/datanodeIoTDBTemplateAuthIT#manageDataBaseTestIoTDBSeriesPermissionIT#ttlOperationsTestgit diff --checkThis PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
AccessControlImplITableAuthCheckerImplTreeAccessCheckVisitorDataNodeQueryMessagesTreeAccessTest